Re: [PATCH] ACPI: resource: Remove "Zen" specific match and quirks

From: Chuanhong Guo
Date: Wed May 17 2023 - 23:54:30 EST


Hi!

On Tue, May 16, 2023 at 5:38 AM Mario Limonciello
<mario.limonciello@xxxxxxx> wrote:
>
> commit 9946e39fe8d0 ("ACPI: resource: skip IRQ override on
> AMD Zen platforms") attempted to overhaul the override logic so it
> didn't apply on X86 AMD Zen systems. This was intentional so that
> systems would prefer DSDT values instead of default MADT value for
> IRQ 1 on Ryzen 6000 systems which use ActiveLow for IRQ1.
>
> This turned out to be a bad assumption because several vendors seem
> to add Interrupt Source Override but don't fix the DSDT. A pile of
> quirks was collecting that proved this wasn't sustaintable.
>
> Adjust the logic so that only IRQ1 is overridden in Ryzen 6000 case.
>
> This effectively reverts the following commits:
> commit 17bb7046e7ce ("ACPI: resource: Do IRQ override on all TongFang
> GMxRGxx")
> commit f3cb9b740869 ("ACPI: resource: do IRQ override on Lenovo 14ALC7")
> commit bfcdf58380b1 ("ACPI: resource: do IRQ override on LENOVO IdeaPad")
> commit 7592b79ba4a9 ("ACPI: resource: do IRQ override on XMG Core 15")
>
> Cc: ofenfisch@xxxxxxxxxxxxxx
> Cc: gch981213@xxxxxxxxx
> Cc: wse@xxxxxxxxxxxxxxxxxxx
> Cc: adam.niederer@xxxxxxxxx
> Cc: adrian@xxxxxxxxx
> Cc: jirislaby@xxxxxxxxxx
> Tested-by: Renjith.Pananchikkal@xxxxxxx
> Tested-by: anson.tsao@xxxxxxx
> Tested-by: Richard.Gong@xxxxxxx
> Reported-by: evilsnoo@xxxxxxxxx
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217394
> Reported-by: ruinairas1992@xxxxxxxxx
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217406
> Fixes: 9946e39fe8d0 ("ACPI: resource: skip IRQ override on AMD Zen platforms")
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>

Tested on Lenovo Thinkbook 14G4+ ARA with Ryzen 7 6800H.
The keyboard still works with this patch applied.

Tested-by: Chuanhong Guo <gch981213@xxxxxxxxx>

--
Regards,
Chuanhong Guo