Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes

From: Linus Walleij
Date: Wed May 17 2023 - 17:21:50 EST


On Wed, May 17, 2023 at 10:39 PM Aaro Koskinen <aaro.koskinen@xxxxxx> wrote:

> When tested w/gpio-descriptors-omap branch, the touchscreen probe fails:
>
> [ 2.378540] SPI driver ads7846 has no spi_device_id for ti,tsc2046
> [ 2.391906] SPI driver ads7846 has no spi_device_id for ti,ads7843
> [ 2.405029] SPI driver ads7846 has no spi_device_id for ti,ads7845
> [ 2.418151] SPI driver ads7846 has no spi_device_id for ti,ads7873

This is just regular noise from SPI device drivers that are missing
spi_device_id.

> [ 2.432556] ads7846 spi2.0: Unknown device model
> [ 2.443817] ads7846: probe of spi2.0 failed with error -22
>
> I don't know if that's caused by any the patches in the branch or some
> other regression. With v6.2 it probes OK.

The device is missing compatible. I fixed it.

Will push the branch after looking at the rest of the comments.

Yours,
Linus Walleij