Re: [PATCH 1/2] arm64: dts: qcom: pmi8998: add flash LED

[Krzysztof Kozlowski]

On 17/05/2023 20:21, Dylan Van Assche wrote:
> Qualcomm PMIC PMI8998 has a 3 channel flash LED driver which is used
> by many phones for 1 or 2 flash LEDs. Each LED can be used in flash mode
> or torch mode. Add the flash LED node to PMI8998 DTS.
> 
> Signed-off-by: Dylan Van Assche <me@xxxxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/pmi8998.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> index ffe587f281d8..89f959353ad5 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> @@ -60,6 +60,12 @@ pmi8998_lpg: pwm {
>  			status = "disabled";
>  		};
>  
> +		pmi8998_flash: led-controller@d300 {
> +			compatible = "qcom,spmi-flash-led";

This cannot be alone.

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).

Best regards,
Krzysztof