Re: [PATCH] kdb: include kdb_private.h for function prototypes

[Doug Anderson]

Hi,

On Wed, May 17, 2023 at 5:48 AM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The kdb_kbd_cleanup_state() is called from another file through
> the kdb_private.h file, but that is not included before the
> definition, causing a W=1 warning:
>
> kernel/debug/kdb/kdb_keyboard.c:198:6: error: no previous prototype for 'kdb_kbd_cleanup_state' [-Werror=missing-prototypes]
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>  kernel/debug/kdb/kdb_keyboard.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>