Re: [PATCH] fbdev: fbmem: mark get_fb_unmapped_area() static

[Geert Uytterhoeven]

Hi Arnd,

On Tue, May 16, 2023 at 10:23 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> There is a global function with this name on sparc, but no
> global declaration:
>
> drivers/video/fbdev/core/fbmem.c:1469:15: error: no previous prototype for 'get_fb_unmapped_area'
>
> Make the generic definition static to avoid this warning. On
> sparc, this is never seen.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Thanks for your patch!

> --- a/drivers/video/fbdev/core/fbmem.c
> +++ b/drivers/video/fbdev/core/fbmem.c
> @@ -1468,7 +1468,7 @@ __releases(&info->lock)
>  }
>
>  #if defined(CONFIG_FB_PROVIDE_GET_FB_UNMAPPED_AREA) && !defined(CONFIG_MMU)
> -unsigned long get_fb_unmapped_area(struct file *filp,
> +static unsigned long get_fb_unmapped_area(struct file *filp,
>                                    unsigned long addr, unsigned long len,
>                                    unsigned long pgoff, unsigned long flags)
>  {

LGTM, as this is unrelated to the SPARC function, and SPARC does
not support nommu (yet? ;-)

drivers/video/fbdev/Kconfig:config FB_PROVIDE_GET_FB_UNMAPPED_AREA
drivers/video/fbdev/Kconfig-    bool
drivers/video/fbdev/Kconfig-    depends on FB
drivers/video/fbdev/Kconfig-    help
drivers/video/fbdev/Kconfig-      Allow generic frame-buffer to
provide get_fb_unmapped_area
drivers/video/fbdev/Kconfig-      function.

Probably you want to update this help text, too. E.g.
"to provide shareable character device support on nommu"?

This seems to be selected only by DRM_STM.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds