Re: [PATCH] scsi: Let scsi_execute_cmd() mark args->sshdr as invalid

[Juergen Gross]

On 17.05.23 04:06, Martin K. Petersen wrote:
> Juergen,
>
> > Some callers of scsi_execute_cmd() (like e.g. sd_spinup_disk()) are
> > passing an uninitialized struct sshdr and don't look at the return
> > value of scsi_execute_cmd() before looking at the contents of that
> > struct.
>
> Which callers? sd_spinup_disk() appears to do the right thing...

Not really. It is calling media_not_present() directly after the call of
scsi_execute_cmd() without checking the result. media_not_present() is looking
at sshdr, which is uninitialized in case of an early error in
scsi_execute_cmd(). The same applies to read_capacity_1[06]().

scsi_test_unit_ready() and scsi_report_lun_scan() have the problem, too.

Do I need to find other examples?


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature