Re: [PATCH v2] watchdog: Prefer use "ref-cycles" for NMI watchdog

From: Song Liu
Date: Wed May 17 2023 - 00:39:32 EST




> On May 16, 2023, at 6:23 PM, Li, Xin3 <xin3.li@xxxxxxxxx> wrote:
>
>> NMI watchdog permanently consumes one hardware counters per CPU on the
>> system. For systems that use many hardware counters, this causes more
>> aggressive time multiplexing of perf events.
>>
>> OTOH, some CPUs (mostly Intel) support "ref-cycles" event, which is rarely
>> used. Try use "ref-cycles" for the watchdog, so that one more hardware
>> counter is available to the user. If the CPU doesn't support "ref-cycles",
>> fall back to "cycles".
>>
>> The downside of this change is that users of "ref-cycles" need to disable
>> nmi_watchdog.
>
> From the discussion in v1, the users don't have to disable the NMI watchdog
> *permanently*, right?

The users need to disable NMI watchdog when using ref-cycles. For example:

# disable nmi_watchdog
sysctl kernel.nmi_watchdog=0

# use ref-cycles
perf stat/record -e ref-cycles ...

# reenable nmi_watchdog
sysctl kernel.nmi_watchdog=1

Thanks,
Song