Re: [PATCH 12/13] ARM: spear: include "pl080.h" for pl080_get_signal() prototype

From: Viresh Kumar
Date: Wed May 17 2023 - 00:34:57 EST


On 16-05-23, 17:31, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> pl080_get_signal() and pl080_put_signal() are declared in pl080.h
> and defined in pl080.c, but this file is missing an include
> of the header:
>
> arch/arm/mach-spear/pl080.c:27:5: error: no previous prototype for 'pl080_get_signal'
> arch/arm/mach-spear/pl080.c:62:6: error: no previous prototype for 'pl080_put_signal'
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> arch/arm/mach-spear/pl080.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-spear/pl080.c b/arch/arm/mach-spear/pl080.c
> index d6b8627d2544..47243a8153d0 100644
> --- a/arch/arm/mach-spear/pl080.c
> +++ b/arch/arm/mach-spear/pl080.c
> @@ -16,6 +16,7 @@
> #include <linux/spinlock_types.h>
> #include "spear.h"
> #include "misc_regs.h"
> +#include "pl080.h"
>
> static spinlock_t lock = __SPIN_LOCK_UNLOCKED(x);

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh