Re: [PATCH] gpu: drm: bridge: No need to set device_driver owner

[Neil Armstrong]

On 13/05/2023 12:12, Anup Sharma wrote:
> There is no need to exclusively set the .owner member of the struct
> device_driver when defining the platform_driver struct. The Linux core
> takes care of setting the .owner member as part of the call to
> module_platform_driver() helper function.
>
> Issue identified using the platform_no_drv_owner.cocci Coccinelle
> semantic patch as:
> drivers/gpu/drm/bridge/samsung-dsim.c:1957:6-11: No need to set .owner here.
> The core will do it.
>
> No functional changes are intended.
>
> Signed-off-by: Anup Sharma <anupnewsmail@xxxxxxxxx>
> ---
>   drivers/gpu/drm/bridge/samsung-dsim.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
> index e0a402a85787..10dc3315e69e 100644
> --- a/drivers/gpu/drm/bridge/samsung-dsim.c
> +++ b/drivers/gpu/drm/bridge/samsung-dsim.c
> @@ -1954,7 +1954,6 @@ static struct platform_driver samsung_dsim_driver = {
>   	.remove = samsung_dsim_remove,
>   	.driver = {
>   		   .name = "samsung-dsim",
> -		   .owner = THIS_MODULE,
>   		   .pm = &samsung_dsim_pm_ops,
>   		   .of_match_table = samsung_dsim_of_match,
>   	},

Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>