Re: [PATCH net-next 2/7] net: lan966x: Add support for offloading pcp table

From: Paolo Abeni
Date: Tue May 16 2023 - 03:08:39 EST


On Mon, 2023-05-15 at 12:16 +0200, Piotr Raczynski wrote:
> On Sun, May 14, 2023 at 10:10:24PM +0200, Horatiu Vultur wrote:

[...]

> > +static int lan966x_dcb_ieee_setapp(struct net_device *dev, struct dcb_app *app)
> > +{
> > + struct dcb_app app_itr;
> > + int err;
> > + u8 prio;
> > +
> > + err = lan966x_dcb_app_validate(dev, app);
> > + if (err)
> > + goto out;
> > +
> > + /* Delete current mapping, if it exists */
> > + prio = dcb_getapp(dev, app);
> > + if (prio) {
> > + app_itr = *app;
> > + app_itr .priority = prio;
> Compiles OK, still looks little weird :).

Since it looks like a v2 is required to update later patches, please
additionally remove the unneeded whitespace above:

app_itr.priority = prio;

Thanks!

Paolo