Re: [PATCH v5 14/26] alpha: Remove empty <uapi/asm/setup.h>

From: Maciej W. Rozycki
Date: Mon May 15 2023 - 20:53:57 EST


On Mon, 6 Mar 2023, Alexandre Ghiti wrote:

> diff --git a/arch/alpha/include/uapi/asm/setup.h b/arch/alpha/include/uapi/asm/setup.h
> deleted file mode 100644
> index 9b3b5ba39b1d..000000000000
> --- a/arch/alpha/include/uapi/asm/setup.h
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> -#ifndef _UAPI__ALPHA_SETUP_H
> -#define _UAPI__ALPHA_SETUP_H
> -
> -#endif /* _UAPI__ALPHA_SETUP_H */

You can't just remove a UAPI header like this, something will break; cf.
arch/arc/include/uapi/asm/setup.h, or arch/x86/include/uapi/asm/setup.h if
you want it brief.

I suggest that you fold it into 01/26 (it makes no sense to have empty
multiple inclusion protection), and likewise for the relevant remaining
headers.

Maciej