Re: [PATCH v8 1/8] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

[Abhinav Kumar]

On 5/15/2023 2:23 PM, Marijn Suijten wrote:
> On 2023-05-15 13:58:35, Abhinav Kumar wrote:
> > On 5/15/2023 1:07 PM, Marijn Suijten wrote:
> > > On 2023-05-15 11:20:02, Abhinav Kumar wrote:
> > > > On 5/14/2023 2:39 PM, Marijn Suijten wrote:
> > > > > DSC*, and mention 1.1 explicitly (since this skips the 1.2 blocks, while
> > > > > the series is clearly aimed at 1.1...).  This was done for the DSC 1.2
> > > > > HW block patch after all.
> > > > >
> > > > > in catalog -> to catalog
> > > > >
> > > > > But it's just two platforms, you can fit MSM8998 and SC8180X in the
> > > > > title.
> > > > >
> > > > > On 2023-05-12 11:00:16, Kuogee Hsieh wrote:
> > > > > > From: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> > > > > >
> > > > > > There are some platforms has DSC blocks but it is not declared at catalog.
> > > > >
> > > > > Some platforms have DSC blocks which have not yet been declared in the
> > > > > catalog.*
> > > > >
> > > > > > For completeness, this patch adds DSC blocks for platforms which missed
> > > > > > them.
> > > > >
> > > > > Drop "this patch":
> > > > >
> > > > >        Complete DSC 1.1 support for all platforms by adding the missing
> > > > >        blocks to MSM8998 and SC8180X.
> > > > >
> > > > > > Signed-off-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> > > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > > > > > ---
> > > > > >     drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h |  7 +++++++
> > > > > >     drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h | 11 +++++++++++
> > > > >
> > > > > How about SC7180, and any other DPU 6.x revision?
> > > >
> > > > Will let kuogee respond to the other nits. There is no DSC in sc7180 /
> > > > sm6115 / qcm2290. So this patch is complete.
> > >
> > > Thank you for checking as I didn't have the DTS close (and it seems
> > > SC7180 would have supported this, but no).  I did check other SoCs in
> > > the DPU 6.x range that are currently floating in my tree and on the
> > > list, which do need their DSC 1.1 block added (both a single block at
> > > 0x81000 downstream, 0x80000 upstream), if you can in a resend Konrad:
> > >
> > > DPU 6.4 in SM6350: https://lore.kernel.org/linux-arm-msm/20230411-topic-straitlagoon_mdss-v3-6-9837d6b3516d@xxxxxxxxxx/
> > > DPU 6.9 in SM6375: https://lore.kernel.org/linux-arm-msm/20230411-topic-straitlagoon_mdss-v3-8-9837d6b3516d@xxxxxxxxxx/
> >
> > If these are still on the list, can Konrad add them to his change as
> > that way his catalog change will be complete? Otherwise I would prefer
> > to add them in a follow up change because marking this change as
> > dependent on a catalog change which adds a new chipset is not right.
>
> The question was for Konrad (and I addressed him by name, not you) as
> his series is not merged and the DSC blocks can be added to it directly
> without depending on this series.  DSC 1.1 is after all available for
> some time now.

Thanks for clarifying. Your reply was cut-off "if you can in a resend 
Konrad" so not sure what you were trying to tell.

> - Marijn