Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

[Kuogee Hsieh]

On 5/14/2023 2:46 PM, Marijn Suijten wrote:
> On 2023-05-12 21:19:19, Dmitry Baryshkov wrote:
> <snip.
> > > +static inline void dpu_hw_dsc_bind_pingpong_blk_1_2(struct dpu_hw_dsc *hw_dsc,
> > > +						    const enum dpu_pingpong pp)
> > > +{
> > > +	struct dpu_hw_blk_reg_map *hw;
> > > +	const struct dpu_dsc_sub_blks *sblk;
> > > +	int mux_cfg = 0xf; /* Disabled */
> > > +
> > > +	hw = &hw_dsc->hw;
> > > +
> > > +	sblk = hw_dsc->caps->sblk;
> > > +
> > > +	if (pp)
> > > +		mux_cfg = (pp - PINGPONG_0) & 0x7;
> > Do we need an unbind support here like we do for the DSC 1.1?
> >
> > > +
> > > +	DPU_REG_WRITE(hw, sblk->ctl.base + DSC_CTL, mux_cfg);
> > > +}
> <snip>
>
> Friendly request to strip/snip unneeded context (as done in this reply)
> to make it easier to spot the conversation, and replies to it.
>
> - Marijn

Thanks for suggestion.

How can I do that?

just manually delete unneeded context?

Or are they other way (tricks) to do it automatically?