Re: [PATCH v8 06/14] mfd: rk8xx-i2c: use device_get_match_data

From: Lee Jones
Date: Mon May 15 2023 - 11:20:18 EST


On Thu, 04 May 2023, Sebastian Reichel wrote:

> Simplify the device identification logic by supplying the relevant
> information via of_match_data. This also removes the dev_info()
> printing the chip version, since that's supplied by the match data
> now.
>
> Due to lack of hardware this change is compile-tested only.
>
> Acked-for-MFD-by: Lee Jones <lee@xxxxxxxxxx>
> Tested-by: Diederik de Haas <didi.debian@xxxxxxxxx> # Rock64, Quartz64 Model A + B
> Tested-by: Vincent Legoll <vincent.legoll@xxxxxxxxx> # Pine64 QuartzPro64
> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
> ---
> drivers/mfd/rk8xx-core.c | 2 -
> drivers/mfd/rk8xx-i2c.c | 89 +++++++++++++++++-----------------------
> 2 files changed, 37 insertions(+), 54 deletions(-)

Applied, thanks

--
Lee Jones [李琼斯]