Re: [PATCH v2 0/3] leds: simatic-ipc-leds-gpio: split up

From: Henning Schild
Date: Mon May 15 2023 - 11:07:13 EST


Am Mon, 15 May 2023 13:12:47 +0100
schrieb Lee Jones <lee@xxxxxxxxxx>:

> On Mon, 15 May 2023, Henning Schild wrote:
>
> > Am Mon, 15 May 2023 10:50:42 +0100
> > schrieb Lee Jones <lee@xxxxxxxxxx>:
> >
> > > On Sat, 13 May 2023, Henning Schild wrote:
> > >
> > > > Ping.
> > > >
> > > > As far as i remember this one should be ready to merge.
> > > >
> > > > ACKed by Hans, and Andy had no objections given the maintainers
> > > > would accept the patches.
> > > >
> > > > So i think it is the maintainers turn now, Pavel and/or Lee i
> > > > guess.
> > >
> > > Looks like there are lots of mail threads in reply to each of the
> > > patches. If these culminated in acceptance, please collect all
> > > of the Acks you've received until this point and submit a
> > > [RESEND]. If there are changes to be made still, please do the
> > > same but submit as a new version.
> >
> > Ok i will send it again and include the ACK from Hans. There would
> > be no code change. Please review the code already, if you find it
> > acceptable we might receive a second ACK from Andy.
>
> Not sure what you mean by 'already'.
>
> I shall not be reviewing this set until it is resent, thanks.

I just sent that v3 you requested. It has one Ack from Hans in p3. And
some minor style things from Andy, which i decided to take in when
having to rebase and test once more.

Looking forward to your feedback on that v3.

regards,
Henning