Re: [PATCH] dt-bindings: usb: usb251xb: correct swap-dx-lanes type to uint32

[Marek Vasut]

On 5/15/23 12:33, Krzysztof Kozlowski wrote:
> The "swap-dx-lanes" was never described as uint8 in original TXT
> bindings and Linuxx driver expects uint32.  Fix the type to match Linux

Linux , one x too many .

> driver expectation and original binding.
>
> Fixes: fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> ---
>
> Cc: mike.looijmans@xxxxxxxx
> ---
>   Documentation/devicetree/bindings/usb/usb251xb.yaml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/usb251xb.yaml b/Documentation/devicetree/bindings/usb/usb251xb.yaml
> index 4d1530816817..ac5b99710332 100644
> --- a/Documentation/devicetree/bindings/usb/usb251xb.yaml
> +++ b/Documentation/devicetree/bindings/usb/usb251xb.yaml
> @@ -231,7 +231,7 @@ properties:
>         power-on sequence to a port until the port has adequate power.
>   
>     swap-dx-lanes:
> -    $ref: /schemas/types.yaml#/definitions/uint8-array
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>       description: |
>         Specifies the ports which will swap the differential-pair (D+/D-),
>         default is not-swapped.

Would it make more sense to update the driver instead ? I doubt you 
could have more than 256 ports on this device after all.