Re: [PATCH] sock: Fix misuse of sk_under_memory_pressure()
From: Eric Dumazet
Date: Mon May 15 2023 - 03:21:32 EST
On Mon, May 15, 2023 at 9:04 AM Abel Wu <wuyun.abel@xxxxxxxxxxxxx> wrote:
>
> Gentle ping :)
>
I still do not understand the patch.
If I do not understand the patch and its changelog now in May 2023,
how will anyone understand it later
when/if a regression is investigated ?
I repeat :
Changelog is evasive, I do not see what practical problem you want to solve.
sk_has_memory_pressure() is not about memcg, simply the fact that a
proto has a non NULL memory_pressure pointer.
I suggest that you answer these questions, and send a V2 with an
updated changelog.
Again, what is the practical problem you want to solve ?
What is the behavior of the current stack that you think is a problem ?
Thanks.