Re: [PATCH] serial: 8250_pci: remove unreachable code for ASIX devices

From: Greg Kroah-Hartman
Date: Sun May 14 2023 - 23:49:57 EST


On Mon, May 15, 2023 at 10:36:30AM +0800, Jiaqing Zhao wrote:
>
>
> On 2023-05-13 18:28, Greg Kroah-Hartman wrote:
> > On Wed, May 10, 2023 at 02:28:56PM +0000, Jiaqing Zhao wrote:
> >> PCI_VENDOR_ID_ASIX (0x9710) is the same as PCI_VENDOR_ID_NETMOS. In
> >> pci_serial_quirks array, the NetMos entry always takes precedence over
> >> the ASIX entry. So the code for ASIX devices is always unreachable,
> >> even when it was initially merged. Since the NetMos vendor driver
> >> doesn't mention such FIFO bug, it's safe to remove the code.
> >>
> >> This reverts commit eb26dfe8aa7e ("8250: add support for ASIX devices
> >> with a FIFO bug").
> >>
> >> Signed-off-by: Jiaqing Zhao <jiaqing.zhao@xxxxxxxxxxxxxxx>
> >
> > Please follow the documented Intel kernel developer requirements before
> > you submit this again, based on the changes that process will require.
> >
> > thanks,
> >
> > greg k-h
>
> Sorry I am unable to find this "Intel kernel developer requirements". Is
> there any link or contact where I can find this information? Thank you.

Contact the Intel Linux developer team and they will point you at them.
This is a company-wide requirement, it is odd that your normal "Here is
how you can contribute to Linux!" training at Intel did not cover it?

thanks,

greg k-h