Re: [PATCH v2 1/4] spi: dt-bindings: Introduce spi-mosi-idle-low flag

From: Mark Brown
Date: Sun May 14 2023 - 20:34:42 EST


On Fri, May 12, 2023 at 08:54:19AM +0200, Börge Strümpfel wrote:
> Am Fr., 12. Mai 2023 um 05:30 Uhr schrieb Mark Brown <broonie@xxxxxxxxxx>:

> > If this is always required for a given device (which I'd expect to be
> > the case) why configure it through DT? I know we've got some legacy
> > stuff like that but not all legacy DT choices were good and no need to
> > continue the pattern.

> Yes this will always be the case for specific spi-device, spi-controller
> combinations. Just to make sure, that I understand your suggestion
> correctly: You propose to check from the specific spi-device-driver, if
> the spi-controller supports this particular mode-bit, and then set it if
> it does and thereby loose the need for the DT entry completely?

Yes, we shouldn't need DT here. Though the device should just be
setting this unconditionally if it's always required.

Attachment: signature.asc
Description: PGP signature