Re: [PATCH v1] drivers/pinconf.c: Remove redundant check for the existence of the member

From: andy . shevchenko
Date: Sun May 14 2023 - 17:10:49 EST


Mon, May 15, 2023 at 12:59:32AM +0800, Lizhe kirjoitti:
> "pin_config_set" in pinconf_ops.
>
> In the function of registering pinctrl_dev, pinctrl_init_controller(),
> a non-null check has already been performed on the members
> pin_config_set and pin_config_group_set in the ops structure.

NAK.

Try to analyse what `if (!foo && !bar)` means from the logic perspective and
deduce from that the problem in your proposal.

P.S. It's not the first wrong proposed change from you. Dunno if you even
trying to read the code...

--
With Best Regards,
Andy Shevchenko