Re: [PATCH v4] dt-bindings: net: nxp,sja1105: document spi-cpol/cpha

From: Conor Dooley
Date: Sun May 14 2023 - 14:32:42 EST


On Sun, May 14, 2023 at 01:57:41PM +0200, Krzysztof Kozlowski wrote:

> +allOf:
> + - $ref: dsa.yaml#/$defs/ethernet-ports
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> + - if:
> + properties:
> + compatible:
> + enum:
> + - nxp,sja1105e
> + - nxp,sja1105t

Is there a particular reason you did not put the "t" variant after the
"s" one?

> + - nxp,sja1105p
> + - nxp,sja1105q
> + - nxp,sja1105r
> + - nxp,sja1105s

Otherwise,
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Thanks,
Conor.

Attachment: signature.asc
Description: PGP signature