Re: [PATCH] loongarch: fix debugfs_create_dir error checking

[Huacai Chen]

Hi, Immad,

On Sat, May 13, 2023 at 10:46 PM <mirimmad@xxxxxxxxxxx> wrote:
>
> From: Immad Mir <mirimmad17@xxxxxxxxx>
>
> The debugfs_create_dir returns ERR_PTR incase of an error and the
> correct way of checking it by using the IS_ERR inline function, and
> not the simple null comparision. This patch fixes this.
>
> Suggested-By: Ivan Orlov <ivan.orlov0322@xxxxxxxxx>
> Signed-off-by: Immad Mir <mirimmad17@xxxxxxxxx>
> ---
>  arch/loongarch/kernel/unaligned.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/kernel/unaligned.c b/arch/loongarch/kernel/unaligned.c
> index bdff825d2..be2a5bdc5 100644
> --- a/arch/loongarch/kernel/unaligned.c
> +++ b/arch/loongarch/kernel/unaligned.c
> @@ -485,7 +485,7 @@ static int __init debugfs_unaligned(void)
>         struct dentry *d;
>
>         d = debugfs_create_dir("loongarch", NULL);
> -       if (!d)
> +       if (IS_ERR(d))
Maybe we need IS_ERR_OR_NULL() here?

Huacai
>                 return -ENOMEM;
>
>         debugfs_create_u32("unaligned_instructions_user",
> --
> 2.40.0
>