Re: [PATCH] dt-bindings: iio: temperature: Add DT bindings for TMP006

From: Jonathan Cameron
Date: Sat May 13 2023 - 14:34:38 EST


On Fri, 12 May 2023 08:28:29 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:

> On 11/05/2023 21:06, Anup Sharma wrote:
> > On Thu, May 11, 2023 at 11:28:50AM +0200, Krzysztof Kozlowski wrote:
> >> On 10/05/2023 20:56, Anup Sharma wrote:
> >>> Add devicetree binding document for TMP006, IR thermopile sensor.
> >>
> >> Why? Where is any user of this? DTS? Driver?
> >>
> >
> > The support for TMP006 is available at driver/iio/temperature
>
> There is no such compatible in the kernel. If you add OF support, you
> should change the driver.

(Very) old driver, so it uses the fallback method that i2c provides to bind to
the compatible with the vendor id dropped via i2c_device_id entry.

Having said that, I'd also prefer the addition of an explicit of_device_id table.
As there is only one supported device in this driver should be trivial.

Thanks,

Jonathan


>
>
> Best regards,
> Krzysztof
>