Re: [PATCH v4 2/3] iio: potentiometer: Add support for the Renesas X9250 potentiometers

From: Jonathan Cameron
Date: Sat May 13 2023 - 14:20:53 EST


On Tue, 9 May 2023 18:08:51 +0200
Herve Codina <herve.codina@xxxxxxxxxxx> wrote:

> The Renesas X9250 integrates four digitally controlled potentiometers.
> On each potentiometer, the X9250T has a 100 kOhms total resistance and
> the X9250U has a 50 kOhms total resistance.
>
> Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx>

As I only noticed one trivial thing I made the change whilst applying.
diff --git a/drivers/iio/potentiometer/x9250.c b/drivers/iio/potentiometer/x9250.c
index 3d4ca18d1f14..7e145d7d14f1 100644
--- a/drivers/iio/potentiometer/x9250.c
+++ b/drivers/iio/potentiometer/x9250.c
@@ -176,10 +176,7 @@ static int x9250_probe(struct spi_device *spi)

x9250 = iio_priv(indio_dev);
x9250->spi = spi;
- x9250->cfg = device_get_match_data(&spi->dev);
- if (!x9250->cfg)
- x9250->cfg = &x9250_cfg[spi_get_device_id(spi)->driver_data];
-
+ x9250->cfg = spi_get_device_match_data(spi);
x9250->wp_gpio = devm_gpiod_get_optional(&spi->dev, "wp", GPIOD_OUT_LOW);
if (IS_ERR(x9250->wp_gpio))
return dev_err_probe(&spi->dev, PTR_ERR(x9250->wp_gpio),