Re: [PATCH v2 0/3] leds: simatic-ipc-leds-gpio: split up

From: Henning Schild
Date: Sat May 13 2023 - 06:11:04 EST


Ping.

As far as i remember this one should be ready to merge.

ACKed by Hans, and Andy had no objections given the maintainers would
accept the patches.

So i think it is the maintainers turn now, Pavel and/or Lee i guess.

Henning

Am Wed, 1 Mar 2023 18:02:12 +0100
schrieb Henning Schild <henning.schild@xxxxxxxxxxx>:

> changes since v1:
> - move from header- to -core.c-based implementation
> - style changes from review
>
> This series mainly splits the one GPIO driver into two. The split
> allows to clearly model runtime and compile time dependencies on the
> GPIO chip drivers.
>
> p1 is kind of not too related to that split but also prepares for more
> GPIO based drivers to come.
>
> p2 takes the driver we had and puts some of its content into a -core,
> to be used by the two drivers.
>
> p3 deals with more fine-grained configuration posibilities and compile
> time dependencies.
>
> It is based on
> [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the GPIO
> providing driver
>
> Henning Schild (3):
> leds: simatic-ipc-leds-gpio: move two extra gpio pins into another
> table
> leds: simatic-ipc-leds-gpio: split up into multiple drivers
> leds: simatic-ipc-leds-gpio: introduce more Kconfig switches
>
> drivers/leds/simple/Kconfig | 31 +++-
> drivers/leds/simple/Makefile | 5 +-
> .../simple/simatic-ipc-leds-gpio-apollolake.c | 64 ++++++++
> .../leds/simple/simatic-ipc-leds-gpio-core.c | 103 +++++++++++++
> .../simple/simatic-ipc-leds-gpio-f7188x.c | 64 ++++++++
> drivers/leds/simple/simatic-ipc-leds-gpio.c | 139
> ------------------ drivers/leds/simple/simatic-ipc-leds-gpio.h |
> 22 +++ drivers/platform/x86/simatic-ipc.c | 7 +-
> 8 files changed, 288 insertions(+), 147 deletions(-)
> create mode 100644
> drivers/leds/simple/simatic-ipc-leds-gpio-apollolake.c create mode
> 100644 drivers/leds/simple/simatic-ipc-leds-gpio-core.c create mode
> 100644 drivers/leds/simple/simatic-ipc-leds-gpio-f7188x.c delete mode
> 100644 drivers/leds/simple/simatic-ipc-leds-gpio.c create mode 100644
> drivers/leds/simple/simatic-ipc-leds-gpio.h
>