Re: [PATCH 2/2] arm64: dts: freescale: Add imx8mp-venice-gw7905-2x

[Krzysztof Kozlowski]

On 12/05/2023 17:07, Tim Harvey wrote:
> On Thu, May 11, 2023 at 10:23 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:

> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw702x.dtsi b/arch/arm6
> 4/boot/dts/freescale/imx8mp-venice-gw702x.dtsi
> index 4fca4aae8f72..74b0fda235ed 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw702x.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw702x.dtsi
> @@ -222,8 +222,6 @@ channel@a2 {
>                 };
> 
>                 fan-controller@0 {
> -                       #address-cells = <1>;
> -                       #size-cells = <0>;
>                         compatible = "gw,gsc-fan";
>                         reg = <0x0a>;
>                 };
> 
> Would that make sense?
> 
> Is it that the fan-controller because it does not have addressable
> child nodes does not need address-cells?

I just looked a bit and requirement of address/size cells seemed odd.
There are no children, it's not a bus etc, so yes, drop it.


Best regards,
Krzysztof