Re: [PATCH 2/2] ufs: don't use the fair tag sharings

From: Christoph Hellwig
Date: Fri May 12 2023 - 10:02:29 EST


On Thu, May 11, 2023 at 08:38:04AM -0700, Bart Van Assche wrote:
> For which devices is the fair sharing algorithm useful? As far as I know the
> legacy block layer did not have an equivalent of the fair sharing algorithm
> and I'm not aware of any complaints about the legacy block layer regarding
> to fairness. This is why I proposed in January to remove the fair sharing
> code entirely. See also https://lore.kernel.org/linux-block/20230103195337.158625-1-bvanassche@xxxxxxx/.

Because the old code did not do tag allocation itself? Either way I
don't think a "I'll opt out for a random driver" is the proper approach
when you think it's not needed. Especially not without any data
explaining why just that driver is a special snowflake.