Re: [PATCH v2 04/14] block: fix not to apply bip information in blk_rq_bio_prep()

From: hch@xxxxxx
Date: Fri May 12 2023 - 09:47:19 EST


> +#if defined(CONFIG_BLK_DEV_INTEGRITY)

The normal style is to use #ifdef.

> + if (bio_integrity(bio))
> + rq->nr_integrity_segments = bio_integrity(bio)->bip_vcnt;
> +#endif
> >

Don't we need to walk the iter here, as it might already have been
advanced? Although it seems nothing in the integrity code follows
that model right now, so I'm not quite sure how it's even working with
clones at the moment.