Re: [PATCH 5/5] s390/uv: Update query for secret-UVCs

[Janosch Frank]

On 5/12/23 14:53, Heiko Carstens wrote:
> On Fri, May 12, 2023 at 11:31:53AM +0200, Steffen Eiden wrote:
> > Update the query struct such that secret-UVC related
> > information can be parsed.
> > Add sysfs files for these new values.
> >
> > Signed-off-by: Steffen Eiden <seiden@xxxxxxxxxxxxx>
> > ---
> >   arch/s390/boot/uv.c        |  4 ++++
> >   arch/s390/include/asm/uv.h | 11 ++++++++++-
> >   arch/s390/kernel/uv.c      | 40 ++++++++++++++++++++++++++++++++++++++
> >   3 files changed, 54 insertions(+), 1 deletion(-)
> ...
> > +static ssize_t uv_query_supp_add_secret_req_ver(struct kobject *kobj,
> > +						struct kobj_attribute *attr, char *page)
> > +{
> > +	return scnprintf(page, PAGE_SIZE, "%lx\n", uv_info.supp_add_secret_req_ver);
> > +}
>
> FWIW, another minor thing: all of these should be sysfs_emit() instead.

Do you want us to move all of them to sysfs_emit() eventually or should 
we keep the scnprintfs() which are already in uv.c ?