Re: [PATCH v1] misc: fastrpc: Reassign memory ownership only for remote heap

[Srinivas Kandagatla]

On 29/03/2023 11:09, Greg KH wrote:
> On Tue, Mar 21, 2023 at 08:53:33PM +0000, Srinivas Kandagatla wrote:
> > On 21/03/2023 10:21, Ekansh Gupta wrote:
> > > The userspace map request for remote heap allocates CMA memory.
> > > The ownership of this memory needs to be reassigned to proper
> > > owners to allow access from the protection domain running on
> > > DSP. This reassigning of ownership is not correct if done for
> > > any other supported flags.
> > >
> > > When any other flag is requested from userspace, fastrpc is
> > > trying to reassign the ownership of memory and this reassignment
> > > is getting skipped for remote heap request which is incorrect.
> > > Add proper flag check to reassign the memory only if remote heap
> > > is requested.
> > >
> > > Fixes: 532ad70c6d44 ("misc: fastrpc: Add mmap request assigning for static PD pool")
> > > Cc: stable <stable@xxxxxxxxxx>
> > > Tested-by: Ekansh Gupta <quic_ekangupt@xxxxxxxxxxx>
> > > Signed-off-by: Ekansh Gupta <quic_ekangupt@xxxxxxxxxxx>
> >
> > Thanks for fixing this,  without this fix the code inside if condition was a
> > dead code.
> >
> >
> > Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
>
> Are you going to be collecting these and sending them on?  If not,
> please do.
Sorry for long delay,
I will take care of collecting fastrpc patches and send it.

--srini



> thanks,
>
> greg k-h