RE: [PATCH v1 1/1] mmc: sdhci-of-dwcmshc: Add runtime PM operations for BlueField-3

[Liming Sun]

> -----Original Message-----
> From: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Sent: Friday, May 12, 2023 3:36 AM
> To: Liming Sun <limings@xxxxxxxxxx>
> Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>; David Thompson
> <davthompson@xxxxxxxxxx>; linux-mmc@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-dwcmshc: Add runtime PM
> operations for BlueField-3
> 
> On Thu, 11 May 2023 at 21:03, Liming Sun <limings@xxxxxxxxxx> wrote:
> >
> > This commit implements the runtime PM operations for BlueField-3 SoC
> > to disable eMMC card clock when idle.
> >
> > Reviewed-by: David Thompson <davthompson@xxxxxxxxxx>
> > Signed-off-by: Liming Sun <limings@xxxxxxxxxx>
> > ---
> >  drivers/mmc/host/sdhci-of-dwcmshc.c | 76
> ++++++++++++++++++++++++++++-
> >  1 file changed, 74 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-
> of-dwcmshc.c
> > index e68cd87998c8..19ce058fc5f0 100644
> > --- a/drivers/mmc/host/sdhci-of-dwcmshc.c
> > +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
> > @@ -15,6 +15,7 @@
> >  #include <linux/module.h>
> >  #include <linux/of.h>
> >  #include <linux/of_device.h>
> > +#include <linux/pm_runtime.h>
> >  #include <linux/reset.h>
> >  #include <linux/sizes.h>
> >
> > @@ -542,8 +543,10 @@ static int dwcmshc_probe(struct platform_device
> *pdev)
> >         }
> >
> >  #ifdef CONFIG_ACPI
> > -       if (pltfm_data == &sdhci_dwcmshc_bf3_pdata)
> > +       if (pltfm_data == &sdhci_dwcmshc_bf3_pdata) {
> >                 sdhci_enable_v4_mode(host);
> > +               pm_runtime_enable(dev);
> 
> Why make this ACPI specific? Wouldn't other platforms benefit from
> this change too?

Sure, let me post v2 to make it generic for sdhci-of-dwcmshc.

> 
> [...]
> 
> Kind regards
> Uffe