Re: [PATCH] ASoC: SOF: Simplify the calculation of variables

[Péter Ujfalusi]

On 12/05/2023 09:42, Jiapeng Chong wrote:
> ./sound/soc/sof/pcm.c:372:27-29: WARNING !A || A && B is equivalent to !A || B.

This is correct.

Reviewed-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx>

> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4938
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---
>  sound/soc/sof/pcm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sof/pcm.c b/sound/soc/sof/pcm.c
> index 567db32173a8..d14e7fd2c2ee 100644
> --- a/sound/soc/sof/pcm.c
> +++ b/sound/soc/sof/pcm.c
> @@ -369,7 +369,7 @@ static int sof_pcm_trigger(struct snd_soc_component *component,
>  	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
>  	case SNDRV_PCM_TRIGGER_STOP:
>  		/* invoke platform trigger to stop DMA even if pcm_ops isn't set or if it failed */
> -		if (!pcm_ops || (pcm_ops && !pcm_ops->platform_stop_during_hw_free))
> +		if (!pcm_ops || !pcm_ops->platform_stop_during_hw_free)
>  			snd_sof_pcm_platform_trigger(sdev, substream, cmd);
>  		break;
>  	default:

-- 
Péter