Re: [PATCH v3 11/19] ext4: fix wrong unit use in ext4_mb_new_blocks

From: Kemeng Shi
Date: Fri May 12 2023 - 04:25:51 EST




on 5/12/2023 2:39 PM, Ojaswin Mujoo wrote:
> On Mon, Apr 17, 2023 at 07:06:09PM +0800, Kemeng Shi wrote:
>> Function ext4_mb_new_blocks_simple needs count in cluster. Function
>
> So there seems to be a typo in the commit header and commit message. I believe
> you mean ext4_mb_free_blocks() and ext4_mb_free_blocks_simple() ?
> Hi Ojaswin, thanks for review. Yes, it's a typo, I mean ext4_free_blocks and
ext4_mb_free_blocks_simple. I will fix the commit in next version.
> If that is the case, once corrected feel free to add:
>
> Reviewed-by: Ojaswin Mujoo <ojaswin@xxxxxxxxxxxxx>


--
Best wishes
Kemeng Shi