RE: [PATCH V2] dt-bindings: usb: dwc3: Add interrupt-names property support for wakeup interrupt

[Mehta, Piyush]

Hi,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Thursday, May 11, 2023 3:05 PM
> To: Mehta, Piyush <piyush.mehta@xxxxxxx>; gregkh@xxxxxxxxxxxxxxxxxxx;
> robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
> conor+dt@xxxxxxxxxx; balbi@xxxxxxxxxx; michal.simek@xxxxxxxxxx
> Cc: linux-usb@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Simek, Michal <michal.simek@xxxxxxx>; Paladugu,
> Siva Durga Prasad <siva.durga.prasad.paladugu@xxxxxxx>; git (AMD-Xilinx)
> <git@xxxxxxx>
> Subject: Re: [PATCH V2] dt-bindings: usb: dwc3: Add interrupt-names property
> support for wakeup interrupt
> 
> On 11/05/2023 09:21, Piyush Mehta wrote:
> > The hibernation feature enabled for Xilinx Versal NET SoC in DWC3 IP.
> > As the DWC3 IP supports the hibernation feature, to handle the wakeup
> > or hibernation interrupt, add host mode "wakeup" interrupt-names
> > optional property in the binding schema to capture remote-wakeup and
> > connect/ disconnect event in the hibernation state.
> >
> > Signed-off-by: Piyush Mehta <piyush.mehta@xxxxxxx>
> > ---
> > Change in V2:
> > -  Addressed ROB review comments
> >  - Updated name of interrupt-names property with "wakeup"
> >  - Move interrupt-names property from dwc3-xilinx core to dwc3 core.
> >
> > Link:
> >
> https://lore.kernel.org/all/CAL_JsqK6_7XD7+w+EQvPPmbmSOpfo3JDb0xDN4St
> u
> > HUm1kgchw@xxxxxxxxxxxxxx/
> > ---
> >  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > index 50edc4da780e..db512769bd80 100644
> > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > @@ -53,6 +53,8 @@ properties:
> >        - const: dwc_usb3
> >        - items:
> >            enum: [host, peripheral, otg]
> > +      - items:
> > +          enum: [dwc_usb3, otg, wakeup]
> 
> You didn't add only "wakeup" but also dwc_usb3 which does not look correct
> here as it is common interrupt. The change does not match commit msg and I
> don't know what you actually want to achieve.
>

We have dedicated irq line for hibernation feature,  "wakeup" irq line triggers hibernation interrupt and the system wakes up.
DWC3 core supports the hibernation feature, we have a dedicated code which is yet to be upstreamed.
As the hibernation feature provided by dwc3-core, so this will be supported by other SOC/vendors.

For this, we need the interrupt-name/ interrupt property. To enable the hibernation feature for
Xilinx Versal NET SoC, the interrupt-name enum would be:
- enum [host, peripheral, otg, wakeup]

Please provide valuable input for the same.

> Best regards,
> Krzysztof

Regards,
Piyush Mehta