Re: [PATCH v2 1/3] Move error interrupt bits to a common header.

[Michal Simek]

On 5/12/23 08:27, Thippeswamy Havalige wrote:
> Moving error interrupt bit macros to a common header file for code
> reusability.

The patch below does more things then just what you described.
You also rename them.

> Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@xxxxxxx>
> Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@xxxxxxx>
> ---
>   drivers/pci/controller/pcie-xilinx-common.h | 30 +++++++++++++++++++++++
>   drivers/pci/controller/pcie-xilinx-cpm.c    | 38 ++++++-----------------------
>   2 files changed, 37 insertions(+), 31 deletions(-)
>   create mode 100644 drivers/pci/controller/pcie-xilinx-common.h
>
> diff --git a/drivers/pci/controller/pcie-xilinx-common.h b/drivers/pci/controller/pcie-xilinx-common.h
> new file mode 100644
> index 0000000..015dba3
> --- /dev/null
> +++ b/drivers/pci/controller/pcie-xilinx-common.h
> @@ -0,0 +1,30 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * (C) Copyright 2019 - 2020, Xilinx, Inc.

And we are at 2023 now.

M