Re: Re: [PATCH] xfs: xfs_nfs_get_inode support zero generation

From: Dave Chinner
Date: Fri May 12 2023 - 02:02:26 EST


On Fri, May 12, 2023 at 10:53:29AM +0800, renlei1@xxxxxxxxxxxxxxx wrote:
> Yup, gen is 0 for the inodes created by libxfs, such as rootino, rbmino, rsumino.
> but those inodes will never be freed, and gen will always zero.

Yes, but why does that even matter for file handle verification?

> so I think bypass the verification if gen==0 is still valid.

Did you think about what happens when an inode->gen
overflows from 0xffffffff to 0 as part of a normal unlink/create
cycle?

-Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx