Re: [PATCH 0/2] statfs: Enforce statfs[64] structure intialization

From: Andrew Morton
Date: Thu May 11 2023 - 23:45:31 EST


On Thu, 11 May 2023 16:35:15 +0200 Heiko Carstens <hca@xxxxxxxxxxxxx> wrote:

> On Thu, May 04, 2023 at 04:40:19PM +0200, Ilya Leoshkevich wrote:
> > This series fixes copying of uninitialized memory to userspace by
> > do_statfs_native() and do_statfs64() on s390.
> >
> > Patch 1 fixes the problem by making the code similar to
> > put_compat_statfs() and put_compat_statfs64().
> >
> > Patch 2 gets rid of the padding which caused the issue; even though it
> > may be considered redundant, it documents that s390 de-facto has an
> > extra f_spare array element.
> >
> > Ilya Leoshkevich (2):
> > statfs: Enforce statfs[64] structure intialization
> > s390/uapi: Cover statfs padding by growing f_spare
> >
> > arch/s390/include/asm/compat.h | 2 +-
> > arch/s390/include/uapi/asm/statfs.h | 4 ++--
> > fs/statfs.c | 4 ++--
> > 3 files changed, 5 insertions(+), 5 deletions(-)
>
> Al, Andrew, should this go via the s390 tree?

I'd say so.