Re: [PATCH v2 1/4] spi: dt-bindings: Introduce spi-mosi-idle-low flag

From: Mark Brown
Date: Thu May 11 2023 - 23:31:08 EST


On Fri, May 12, 2023 at 01:13:14AM +0200, Boerge Struempfel wrote:
> Some spi controller switch the mosi line to high, whenever they are
> idle. This may not be desired in all use cases. For example neopixel
> leds can get confused and flicker due to misinterpreting the idle state.
> Therefore, we introduce a new spi-mode bit, with which the idle behaviour
> can be overwritten on a per device basis.
>
> Signed-off-by: Boerge Struempfel <bstruempfel@xxxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/spi/spi-peripheral-props.yaml | 6 ++++++

If this is always required for a given device (which I'd expect to be
the case) why configure it through DT? I know we've got some legacy
stuff like that but not all legacy DT choices were good and no need to
continue the pattern.

Attachment: signature.asc
Description: PGP signature