Re: [PATCH 0/4] Fix type confusion in page_table_check

From: Christoph Hellwig
Date: Thu May 11 2023 - 11:32:17 EST


On Thu, May 11, 2023 at 09:44:55PM +0800, Ruihan Li wrote:
> Christoph's patch perfectly fixes _one_ problem: kmalloc'ed memory
> cannot be mapped to user space. However, as I detailed in the commit
> message, this series of patches fixes _three_ problems.

FYI, I agree with you. My simple patch was sent before reading
your new series, and is a strict subset of it.

> I have to say that the original code is quite buggy. In the
> gen_pool_dma_alloc path, there is no guarantee of page alignment.

I also find this whole interface very problematic to start with,
but that's a separate discussion for later.