Re: [PATCH v12 06/13] HP BIOSCFG driver - passwdobj-attributes

[Jorge Lopez]

On Thu, May 11, 2023 at 4:09 AM Ilpo Järvinen
<ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote:
>
> On Wed, 10 May 2023, Jorge Lopez wrote:
>
> > On Tue, May 9, 2023 at 7:34 AM Ilpo Järvinen
> > <ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote:
> > >
> > > On Fri, 5 May 2023, Jorge Lopez wrote:
> > >
> > > > HP BIOS Configuration driver purpose is to provide a driver supporting
> > > > the latest sysfs class firmware attributes framework allowing the user
> > > > to change BIOS settings and security solutions on HP Inc.’s commercial
> > > > notebooks.
> > > >
> > > > Many features of HP Commercial notebooks can be managed using Windows
> > > > Management Instrumentation (WMI). WMI is an implementation of Web-Based
> > > > Enterprise Management (WBEM) that provides a standards-based interface
> > > > for changing and monitoring system settings. HP BIOSCFG driver provides
> > > > a native Linux solution and the exposed features facilitates the
> > > > migration to Linux environments.
> > > >
> > > > The Linux security features to be provided in hp-bioscfg driver enables
> > > > managing the BIOS settings and security solutions via sysfs, a virtual
> > > > filesystem that can be used by user-mode applications. The new
> > > > documentation cover HP-specific firmware sysfs attributes such Secure
> > > > Platform Management and Sure Start. Each section provides security
> > > > feature description and identifies sysfs directories and files exposed
> > > > by the driver.
> > > >
> > > > Many HP Commercial notebooks include a feature called Secure Platform
> > > > Management (SPM), which replaces older password-based BIOS settings
> > > > management with public key cryptography. PC secure product management
> > > > begins when a target system is provisioned with cryptographic keys
> > > > that are used to ensure the integrity of communications between system
> > > > management utilities and the BIOS.
> > > >
> > > > HP Commercial notebooks have several BIOS settings that control its
> > > > behaviour and capabilities, many of which are related to security.
> > > > To prevent unauthorized changes to these settings, the system can
> > > > be configured to use a cryptographic signature-based authorization
> > > > string that the BIOS will use to verify authorization to modify the
> > > > setting.
> > > >
> > > > Linux Security components are under development and not published yet.
> > > > The only linux component is the driver (hp bioscfg) at this time.
> > > > Other published security components are under Windows.
> > > >
> > > > Signed-off-by: Jorge Lopez <jorge.lopez2@xxxxxx>
> > > >
> > > > ---
> > > > Based on the latest platform-drivers-x86.git/for-next
> > >
> > > FYI, for me you don't need to reply into the comments where you'll be
> > > following the review suggestion. It saves us both time if we focus on
> > > points where there's more to discuss.
>
>
> > > > +                     /*
> > > > +                      * This HACK is needed to keep the expected
> > > > +                      * element list pointing to the right obj[elem].type
> > > > +                      * when the size is zero.  PREREQUISITES
> > >
> > > Please remove all these double space from your patches (should be easy
> > > to find them with grep). Please check if your editor adds them e.g., when
> > > reflowing text.
> >
> > What double spaces are you referring to?
>
> There's "zero.  PREREQUISITES" so double space after the full stop. We
> don't use them in the kernel comments.
>
> It could be that your editor auto inserts the second space (by default)
> when e.g. reflowing text because it's some English rule to use two spaces
> there.
>
>

Thank you for the clarification.  I checked and fixed all double
spaces in all source files
> --
>  i.