Re: [PATCH] scsi: Let scsi_execute_cmd() mark args->sshdr as invalid

From: Bart Van Assche
Date: Thu May 11 2023 - 08:50:16 EST


On 5/11/23 05:34, Juergen Gross wrote:
Some callers of scsi_execute_cmd() (like e.g. sd_spinup_disk()) are
passing an uninitialized struct sshdr and don't look at the return
value of scsi_execute_cmd() before looking at the contents of that
struct.

Shouldn't the scsi_execute_cmd() callers be fixed instead of modifying scsi_execute_cmd(), e.g. by zero-initializing the sshdr structure?

Thanks,

Bart.