Re: [PATCH net-next v2 1/2] dt-bindings: net: cdns,macb: Add rx-watermark property

From: Conor Dooley
Date: Thu May 11 2023 - 03:26:22 EST


On Thu, May 11, 2023 at 01:12:13AM -0600, Pranavi Somisetty wrote:
> watermark value is the minimum amount of packet data
> required to activate the forwarding process. The watermark
> implementation and maximum size is dependent on the device
> where Cadence MACB/GEM is used.
>
> Signed-off-by: Pranavi Somisetty <pranavi.somisetty@xxxxxxx>

Please send dt-binding patches to the dt-binding maintainers and list.
get_maintainer.pl should have told you to do so & without having done
so, the bindings will not get tested :/

Thanks,
Conor.

> ---
> Documentation/devicetree/bindings/net/cdns,macb.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index bef5e0f895be..779bc25cf005 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -109,6 +109,13 @@ properties:
> power-domains:
> maxItems: 1
>
> + rx-watermark:
> + maxItems: 1
> + $ref: /schemas/types.yaml#/definitions/uint16
> + description:
> + Set watermark value for pbuf_rxcutthru reg and enable
> + rx partial store and forward.
> +
> '#address-cells':
> const: 1
>
> @@ -166,6 +173,7 @@ examples:
> compatible = "cdns,macb";
> reg = <0xfffc4000 0x4000>;
> interrupts = <21>;
> + rx-watermark = /bits/ 16 <0x44>;
> phy-mode = "rmii";
> local-mac-address = [3a 0e 03 04 05 06];
> clock-names = "pclk", "hclk", "tx_clk";
> --
> 2.36.1
>

Attachment: signature.asc
Description: PGP signature