RE: [PATCH rcu 3/6] rcu/rcuscale: Move rcu_scale_*() after kfree_scale_cleanup()

[Zhuo, Qiuxu]

> From: Joel Fernandes <joel@xxxxxxxxxxxxxxxxx>
> Sent: Thursday, May 11, 2023 1:23 PM
> To: Paul E. McKenney <paulmck@xxxxxxxxxx>
> Cc: rcu@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; kernel-
> team@xxxxxxxx; rostedt@xxxxxxxxxxx; Zhuo, Qiuxu
> <qiuxu.zhuo@xxxxxxxxx>
> Subject: Re: [PATCH rcu 3/6] rcu/rcuscale: Move rcu_scale_*() after
> kfree_scale_cleanup()
> 
> On Wed, May 10, 2023 at 10:12 AM Paul E. McKenney <paulmck@xxxxxxxxxx>
> wrote:
> >
> > From: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>
> >
> > This code-movement-only commit moves the rcu_scale_cleanup() and
> > rcu_scale_shutdown() functions to follow kfree_scale_cleanup().
> > This is code movement is in preparation for a bug-fix patch that
> > invokes
> > kfree_scale_cleanup() from rcu_scale_cleanup().
> >
> > Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>
> > Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxx>
> > ---
> >  kernel/rcu/rcuscale.c | 194
> > +++++++++++++++++++++---------------------
> >  1 file changed, 97 insertions(+), 97 deletions(-)
> 
> I wish diff was better at showing what really changed. The meld tool can help
> but its gui...
> 
> Should I run meld later (I'm out at a conference so no access to meld-capable
> machines) or are we sufficiently confident that the lines were moved as-is ? :)
> 

Thank you, Joel for this concern. Good to know the meld diff GUI tool. 
I just run the command below and confirmed that the lines were moved 
as-is: rcu_scale_{cleanup,shutdown}() follows kfree_scale_cleanup().
You may double check it ;-).

      meld --diff ./rcuscale.c.before ./rcuscale.c.after

-Qiuxu

>  - Joel