Re: [PATCH rcu 6/6] torture: Remove duplicated argument -enable-kvm for ppc64

From: Zhouyi Zhou
Date: Thu May 11 2023 - 02:19:15 EST


On Thu, May 11, 2023 at 1:26 PM Joel Fernandes <joel@xxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, May 10, 2023 at 10:13 AM Paul E. McKenney <paulmck@xxxxxxxxxx> wrote:
> >
> > From: Zhouyi Zhou <zhouzhouyi@xxxxxxxxx>
> >
> > The qemu argument -enable-kvm is duplicated because the qemu_args bash
> > variable in kvm-test-1-run.sh has already provides it. This commit
>
> drop the has.
Thank Joel for the fix ;-)
Should I resend the patch, or would Paul do me the favor instead ;-)

Thank you all
Zhouyi
>
> - Joel
>
> > therefore removes the ppc64-specific copy in functions.sh.
> >
> > Signed-off-by: Zhouyi Zhou <zhouzhouyi@xxxxxxxxx>
> > Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxx>
> > ---
> > tools/testing/selftests/rcutorture/bin/functions.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/rcutorture/bin/functions.sh b/tools/testing/selftests/rcutorture/bin/functions.sh
> > index b52d5069563c..48b9147e8c91 100644
> > --- a/tools/testing/selftests/rcutorture/bin/functions.sh
> > +++ b/tools/testing/selftests/rcutorture/bin/functions.sh
> > @@ -250,7 +250,7 @@ identify_qemu_args () {
> > echo -machine virt,gic-version=host -cpu host
> > ;;
> > qemu-system-ppc64)
> > - echo -enable-kvm -M pseries -nodefaults
> > + echo -M pseries -nodefaults
> > echo -device spapr-vscsi
> > if test -n "$TORTURE_QEMU_INTERACTIVE" -a -n "$TORTURE_QEMU_MAC"
> > then
> > --
> > 2.40.1
> >