Re: [PATCH] RDMA/core: Use fdget() and fdput()

From: Al Viro
Date: Thu May 11 2023 - 01:42:55 EST


On Fri, May 05, 2023 at 11:33:57AM +0800, ye.xingchen@xxxxxxxxxx wrote:
> From: Ye Xingchen <ye.xingchen@xxxxxxxxxx>
>
> convert the fget()/fput() uses to fdget()/fdput().

NAK on the entire series. *IF* you do that kind of replacements,
you need to understand what you are doing; it's not "fdget() is
like fget(), only better; using it will improve things".

If that comes from seeing my patch series doing fget() to
fdget() conversions, you might consider the possibility that
I *do* know how to use grep. And that there might be some
objective difference between the instances that had been changed
and the one that had been left alone. You could try to figure it
out. Or look through the list archives. Or ask...

Al, more than slightly offended by the implications ;-/