Re: [PATCH 5.15 000/370] 5.15.111-rc2 review

From: Stephen Rothwell
Date: Wed May 10 2023 - 20:57:00 EST


Hi Linus,

On Wed, 10 May 2023 18:09:35 -0500 Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, May 10, 2023 at 5:58 PM Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > Thanks! Turns out someone put the wrong "Fixes:" tag in that commit
> > which is why I missed it.
>
> Hmm. Presumably the real commit ceeadb83aea2 at some point got
> rebased, and had had that other mentioned SHA1 before that.
>
> It might be a good idea in general - not just for stable - if we had
> some automation that said "this refers to a commit ID that doesn't
> exist".

In linux-next, I report various problems with Fixes tags including when
the SHA1 doesn't exist (or is not reachable from the fixing commit.
Sometimes they are corrected, sometimes not (especially if it is a non
rebasing branch).

--
Cheers,
Stephen Rothwell

Attachment: pgpd4vvQmmdqr.pgp
Description: OpenPGP digital signature