Re: [PATCH] firewire: net: fix unexpected release of object for asynchronous request packet

From: Takashi Sakamoto
Date: Wed May 10 2023 - 20:08:44 EST


On Wed, May 10, 2023 at 12:12:05PM +0900, Takashi Sakamoto wrote:
> The lifetime of object for asynchronous request packet is now maintained
> by reference counting, while current implementation of firewire-net
> releases the passed object in the handler.
>
> This commit fixes the bug.
>
> Reported-by: Dan Carpenter <error27@xxxxxxxxx>
> Link: https://lore.kernel.org/lkml/Y%2Fymx6WZIAlrtjLc@workstation/
> Fixes: 13a55d6bb15f ("firewire: core: use kref structure to maintain lifetime of data for fw_request structure")
> Signed-off-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
> ---
> drivers/firewire/net.c | 21 +++++++++++----------
> 1 file changed, 11 insertions(+), 10 deletions(-)

The patch is applied to for-linus branch and will be sent to mainline
within a few days.


Regards

Takashi Sakamoto