Re: [PATCH v2 5/5] dt-bindings: net: ftgmac100: convert to yaml version from txt

[Ivan Mikhaylov]

On Wed, 2023-05-10 at 16:50 +0200, Krzysztof Kozlowski wrote:
> On 09/05/2023 16:35, Ivan Mikhaylov wrote:
> > Signed-off-by: Ivan Mikhaylov <fr0st61te@xxxxxxxxx>
> 
> Need some commit msg.
> 
> 
> > ---
> >  .../bindings/net/faraday,ftgmac100.yaml       | 110
> > ++++++++++++++++++
> 
> Missing actual conversion (removal).
> 
> >  1 file changed, 110 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > new file mode 100644
> > index 000000000000..98cd142f74bb
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > @@ -0,0 +1,110 @@
> > +# SPDX-License-Identifier: GPL-2.0
> 
> Dual-license, unless you copied some chunks of old binding... but was
> there old binding?

Krzysztof, I copied a lot from old one ftgmac100.txt.

> 
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/net/faraday,ftgmac100.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Faraday Technology FTGMAC100 gigabit ethernet controller
> > +
> > +allOf:
> > +  - $ref: "ethernet-controller.yaml#"
> 
> Drop quotes.
> 
> 
> > +
> > +maintainers:
> > +  - Po-Yu Chuang <ratbert@xxxxxxxxxxxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - const: faraday,ftgmac100
> > +      - items:
> > +          - enum:
> > +              - aspeed,ast2400-mac
> > +              - aspeed,ast2500-mac
> > +              - aspeed,ast2600-mac
> > +          - const: faraday,ftgmac100
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    description: |
> > +      In accordance with the generic clock bindings.
> 
> Drop this part. Obvious.
> 
> >  Must describe the MAC
> > +      IP clock, and optionally an RMII RCLK gate for the
> > AST2500/AST2600. The
> > +      required MAC clock must be the first cell.
> 
> The cells depend on clock provider. Do you mean something else?

It's exactly from ftgmac100.txt, this section without any changes, I
didn't add anything new in the sentence.

> 
> > +    minItems: 1
> > +    maxItems: 2
> > +
> > +  clock-names:
> > +    items:
> > +      - enum:
> > +          - MACCLK
> > +          - RCLK
> 
> This does not allow two clocks... List all the items and add
> minItems: 1.
> 
> 
> > +
> > +  phy-mode:
> > +    enum:
> > +      - rgmii
> > +      - rmii
> > +
> > +  phy-handle: true
> > +
> > +  use-ncsi:
> > +    description: |
> 
> Do not need '|' unless you need to preserve formatting.
> 
> I will stop review, because it depends whether this is true
> conversion
> or new binding.
> 

I've tried to convert it from ftgmac100.txt, everything is same in it
except mac-address-increment option with explanation for which purpose
it there, need I divide conversion from that option or is it fine in
one?

Thanks.