Re: [PATCH 6.1 000/610] 6.1.28-rc2 review

From: Roger Pau Monné
Date: Wed May 10 2023 - 09:20:07 EST


On Wed, May 10, 2023 at 01:48:49PM +0200, Pavel Machek wrote:
> Hi!
>
> > This is the start of the stable review cycle for the 6.1.28 release.
> > There are 610 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
>
>
> > Sean Anderson <seanga2@xxxxxxxxx>
> > net: sunhme: Fix uninitialized return code
>
> This one is wrong for stable. err is still initialzied to 0, which is
> wrong thing to do. Mainline is ok, but fix does not work for 6.1.
>
> > Roger Pau Monne <roger.pau@xxxxxxxxxx>
> > ACPI: processor: Fix evaluating _PDC method when running as Xen dom0
>
> If the condition can be handled (and code has "return false"), it
> should use WARN, not BUG.

Feel free to send a followup fix.

Such dummy handler getting caller is a sign of an error elsewhere:
someone playing with Kconfig logic or trying to add _PDC / Xen support
to a different architecture, so I think it's fine to BUG in that
case.

Thanks, Roger.