Re: [PATCH v4 1/3] arm64: dts: Add device tree for the Emtop SOM IMX8MM

From: Krzysztof Kozlowski
Date: Wed May 10 2023 - 09:00:08 EST


On 10/05/2023 13:23, Himanshu Bhavani wrote:
> Add a device tree file describing the Emtop SOM IMX8MM
>
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@xxxxxxxxxxxxxxxxx>


> +&iomuxc {
> + pinctrl_gpio_led: gpioledgrp {
> + fsl,pins = <
> + MX8MM_IOMUXC_NAND_READY_B_GPIO3_IO16 0x19
> + MX8MM_IOMUXC_SAI3_RXC_GPIO4_IO29 0x19
> + >;
> + };
> +
> + pinctrl_i2c1: i2c1grp {
> + fsl,pins = <
> + MX8MM_IOMUXC_I2C1_SCL_I2C1_SCL 0x400001c3
> + MX8MM_IOMUXC_I2C1_SDA_I2C1_SDA 0x400001c3
> + >;
> + };
> +
> + pinctrl_pmic: pmicirq {

No improvements.

Do not send more than one version per 24h and allow others reviewers to
actually review.

Best regards,
Krzysztof